Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #31

Merged
merged 10 commits into from
Nov 12, 2021
Merged

Migrate to GitHub Actions #31

merged 10 commits into from
Nov 12, 2021

Conversation

stephen-fox
Copy link
Contributor

This pull request migrates the drone CI configuration to GitHub Actions.

Per the "docker/build-push-action" documentation, any changes made
to files preceding this Action will be discarded / ignored. As a result,
any resolved git LFS files will be ignored. Because the repo. contains
one or more git LFS'ed tar file, the file(s) created by the "checkout"
action will be returned to LFS pointer text files when the "build-push"
action runs. This does not bode well for the Docker image build process,
which attempts to untar said pointer files.

Refer to the following URLs for more information:

- https://github.com/docker/build-push-action/#usage
- https://stackoverflow.com/a/66453723
The "docker/metadata" Action is pretty unclear about this...

Refer to the following URL for more information:

- https://github.com/docker/metadata-action#tags-input
Copy link
Member

@nshalman nshalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@nshalman
Copy link
Member

This would probably be cleaner squashed down to a single commit before merging.

@stephen-fox stephen-fox merged commit 7b30f46 into master Nov 12, 2021
@stephen-fox stephen-fox deleted the migrate-to-github-actions branch November 12, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants